From: Elijah Newren <newren@gmail.com>
Date: Sat, 01 Apr 2023 19:32:48 GMT
Subject: Re: [PATCH 0/4] rebase: cleanup merge strategy option handling
Message-ID: <CABPp-BHP1fp2-Dnc4O=yhDJq2-iNGAn7rJn0p_rhjYv2LaBOag@mail.gmail.com>
In-Reply-To: <cover.1678893298.git.phillip.wood@dunelm.org.uk>

On Wed, Mar 15, 2023 at 8:39 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Cleanup the handling of --strategy-option now that we no longer need
> to support "--preserve-merges" and properly quote the argument when
> saving it to disc.

Nice!  Thanks for taking the time to do these kinds of cleanups.
Overall the code looks pretty good, but I left a few
comments/questions on patches 3 & 4.