From: Elijah Newren <newren@gmail.com>
Date: Tue, 07 Dec 2021 21:13:56 GMT
Subject: Re: [PATCH 4/6] git-sparse-checkout.txt: update to document that set handles init
Message-ID: <CABPp-BH1nb0XBgNbLLrmbtoK6UfJHgeTwQvDPVn2RcaUKddNzA@mail.gmail.com>
In-Reply-To: <7c2a8b0e-a387-1166-ea02-e5792537aefa@gmail.com>

On Tue, Dec 7, 2021 at 12:42 PM Lessley Dennington
<lessleydennington@gmail.com> wrote:
>
> On 12/4/21 12:00 PM, Elijah Newren via GitGitGadget wrote:
> > From: Elijah Newren <newren@gmail.com>
> >
...
> > ++
> > +Historically, `set` did not used to handle all the necessary config
> > +settings, which meant that both `init` and `set` had to be called.
> > +Invoking both meant the `init` step would first remove nearly all
> > +tracked files (and in cone mode, ignored files too), then the `set`
> > +step would add many of the tracked files (but not ignored files) back.
> > +In addition to the lost files, the performance and UI of this
> > +combination was poor.
> > ++
> Super nit: Perhaps update '`set` did not used to handle' to '`set` did not
> handle'.

Yeah, that sounds better.  I'll wait a bit longer for other comments,
then send a fix for this along with any other needed fixes (even if
just included Acks & Reviewed-bys I get).  Thanks!