From: Elijah Newren <newren@gmail.com>
Date: Sat, 17 Oct 2020 23:43:10 GMT
Subject: Re: [PATCH v5 1/3] test-lib: allow selecting tests by substring/glob with --run
Message-ID: <CABPp-BGXpjYkHEYb_WR0Miy+dHLtZWLjFb3G-EhSi+AOx0voHg@mail.gmail.com>
In-Reply-To: <89279674-a1b5-930a-e682-b47aafeb11b7@gmail.com>

On Fri, Oct 16, 2020 at 4:25 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
>
> On 2020-10-17 00:50, Elijah Newren via GitGitGadget wrote:
>
> [trim]
>
> > diff --git a/t/test-lib.sh b/t/test-lib.sh
> > index ef31f40037..debfd73fd6 100644
> > --- a/t/test-lib.sh
> > +++ b/t/test-lib.sh
> > @@ -769,6 +769,8 @@ match_pattern_list () {
> >  }
> >
> >  match_test_selector_list () {
> > +     operation="$1"
> > +     shift
> >       title="$1"
> >       shift
> >       arg="$1"
> > @@ -777,7 +779,7 @@ match_test_selector_list () {
> >
> >       # Both commas and whitespace are accepted as separators.
>
> This comment becomes outdated with the change below.

Sigh...indeed.  Thanks for pointing it out; I'll send out v6 soon with the fix.