From: Elijah Newren <newren@gmail.com>
Date: Thu, 20 Nov 2025 07:01:13 GMT
Subject: Re: [PATCH v6 02/11] replay: extract logic to pick commits
Message-ID: <CABPp-BGBWaXOtt1_TvkJDAuLxVNC2UAvM+g89avPRBK9Wrb5RA@mail.gmail.com>
In-Reply-To: <073e9a8c-3f6f-4e5c-862a-da59043eb16f@gmail.com>

On Mon, Nov 17, 2025 at 8:27 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> Hi Patrick
>
> On 27/10/2025 11:33, Patrick Steinhardt wrote:
> > We're about to add a new git-history(1) command that will reuse some of
> > the same infrastructure as git-replay(1). To prepare for this, extract
> > the logic to pick a commit into a new "replay.c" file so that it can be
> > shared between both commands.
> >
> > Rename the function to have a "replay_" prefix to clearly indicate its
> > subsystem.
>
> I'm sorry it has taken me so long to get round to looking at this, I've
> been intending to read through this series ever since you re-rolled
> after the contributor summit.
>
> This patch looks good, the only changes to the moved code are to
> namespace the function which become public. I'm very pleased to see us
> switching to using the replay machinery.

The _two_ functions which become public; otherwise, agreed with
Phillip's review comments.