From: Elijah Newren <newren@gmail.com>
Date: Thu, 23 Feb 2023 18:13:45 GMT
Subject: Re: [PATCH 02/16] treewide: remove unnecessary git-compat-util.h includes in headers
Message-ID: <CABPp-BG+Um619phvWP8iMs_zBXS5NwH__AHeJeVDB2ctG7jRCw@mail.gmail.com>
In-Reply-To: <14c2e90d-e68b-d0ad-f8d4-1842663b33c9@github.com>

On Thu, Feb 23, 2023 at 5:52 AM Derrick Stolee <derrickstolee@github.com> wrote:
>
> On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:
> > From: Elijah Newren <newren@gmail.com>
> >
> > Since git-compat-util.h needs to be included first in C files, having it
> > appear in header files is unnecessary.  More importantly, having it
> > included in header files seems to lead to folks leaving it out of C
> > files, which makes it harder to verify that the rule is being followed.
> > Remove it from header files, other than the ones that have been approved
> > as alternate first includes.
> ...
> >  compat/fsmonitor/fsm-ipc-win32.c       | 1 +
> >  compat/fsmonitor/fsm-settings-darwin.c | 1 +
>
> It looks like you have a couple .c files here that belong in the
> previous patch.

Oops, indeed.  Bad squash.  (I tended to ignore files under compat/
thinking they were special, but then later found out they also needed
to be fixed so that things would work right.)

Thanks for catching; will fix.