From: Elijah Newren <newren@gmail.com>
Date: Mon, 02 Dec 2024 23:48:45 GMT
Subject: Re: rev-list --ancestry-path with arg - bug or undocumented requirement
Message-ID: <CABPp-BFzaf3K=LDk+Yp271M6hxdoPdW0G_T3OeNzfUEfkSCxuw@mail.gmail.com>
In-Reply-To: <CADYQcGpyTL18N2t8t-HwafB8VEVbBt452fsE0yMBvRvZd1mbVw@mail.gmail.com>

On Mon, Dec 2, 2024 at 11:45 AM Kai Koponen <kaikoponen@google.com> wrote:
>
> From 447a2367f8d3318e69adccc1b011b0d04792e438 Mon Sep 17 00:00:00 2001
> From: Kai Koponen <kaikoponen@google.com>
> Date: Mon, 2 Dec 2024 19:32:25 +0000
> Subject: [PATCH] doc: mention rev-list --ancestry-path restrictions
>
> Signed-off-by: Kai Koponen <kaikopone@google.com>
> ---
>  Documentation/rev-list-options.txt | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/rev-list-options.txt
> b/Documentation/rev-list-options.txt
> index 00ccf68744..1c678294af 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -412,12 +412,13 @@ Default mode::
>
>  --ancestry-path[=<commit>]::
>   When given a range of commits to display (e.g. 'commit1..commit2'
> - or 'commit2 {caret}commit1'), only display commits in that range
> - that are ancestors of <commit>, descendants of <commit>, or
> - <commit> itself.  If no commit is specified, use 'commit1' (the
> - excluded part of the range) as <commit>.  Can be passed multiple
> - times; if so, a commit is included if it is any of the commits
> - given or if it is an ancestor or descendant of one of them.
> + or 'commit2 {caret}commit1'), and a commit <commit> in that range,
> + only display commits in that range that are ancestors of <commit>,
> + descendants of <commit>, or <commit> itself. If no commit is
> + specified, use 'commit1' (the excluded part of the range) as
> + <commit>.  Can be passed multiple times; if so, a commit is
> + included if it is any of the commits given or if it is an ancestor
> + or descendant of one of them.

where the changes are the insertion of the phrase "and a commit
<commit> in that range,", which nicely captures the restriction.

This patch looks good to me, thanks.

>
>  A more detailed explanation follows.
>
> --
> 2.47.0.338.g60cca15819-goog