From: Elijah Newren <newren@gmail.com>
Date: Wed, 09 Feb 2022 00:26:23 GMT
Subject: Re: [PATCH 08/11] bisect--helper: using `--bisect-state` without an argument is a bug
Message-ID: <CABPp-BFfaOmmW6aX=3nyLQjKsK7Y7cNMKRUqGHTgSdGP3F1=-g@mail.gmail.com>
In-Reply-To: <1b14ed3d7976b8fe4149822dcbb32343e0554a38.1643328752.git.gitgitgadget@gmail.com>

On Fri, Jan 28, 2022 at 3:30 PM Johannes Schindelin via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The `bisect--helper` command is not expected to be used directly by the
> user. Therefore, it is a bug if it receives no argument to the
> `--bisect-state` command mode, not a user error. Which means that we
> need to call `BUG()` instead of `die()`.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  builtin/bisect--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 4450305c81c..009c919a989 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -872,7 +872,7 @@ static enum bisect_error bisect_state(struct bisect_terms *terms, const char **a
>         struct oid_array revs = OID_ARRAY_INIT;
>
>         if (!argc)
> -               return error(_("Please call `--bisect-state` with at least one argument"));
> +               BUG("bisect_state() called without argument");
>
>         if (bisect_autostart(terms))
>                 return BISECT_FAILED;
> --
> gitgitgadget

Makes sense.