From: Elijah Newren Date: Wed, 03 May 2023 04:11:16 GMT Subject: Re: [PATCH v3 0/6] t: fix unused files, part 2 Message-ID: In-Reply-To: On Mon, May 1, 2023 at 3:04 PM Junio C Hamano wrote: > > Andrei Rybak writes: > > > Creation of files from redirecting output of Git commands in tests has been > > removed for files which aren't being used for assertions. CC'ed are authors of > > the affected tests. > > > > v1 cover letter: > > https://lore.kernel.org/git/20230401212858.266508-1-rybak.a.v@gmail.com/ > > v2 cover letter: > > https://lore.kernel.org/git/20230403223338.468025-1-rybak.a.v@gmail.com/ > > This round has not seen any further comments; shall we consider it > pretty much done and ready to move to 'next' by now? I think so. I read through the series. I also read Ævar's and Andrei's extended comments on v2. Ævar does bring up good points about whether we should be testing more, but Andrei I think did a good investigation, cc'ed original code authors (who would be the right ones to comment on whether those other things should be tested), etc. The tests as-is before this series are harder than necessary to understand, and Andrei cleans them up. It feels like good forward progress to me, even if there _might_ be a better eventual optimal. Reviewed-by: Elijah Newren