From: Elijah Newren <newren@gmail.com>
Date: Tue, 14 Nov 2017 18:38:09 GMT
Subject: Re: [PATCH 21/30] merge-recursive: Add get_directory_renames()
Message-ID: <CABPp-BEsEwqAZWtHVe9zhn_KtnLo9yv55666FAiDsMEw62yZoA@mail.gmail.com>
In-Reply-To: <xmqqmv3p4ebo.fsf@gitster.mtv.corp.google.com>

On Mon, Nov 13, 2017 at 9:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Elijah Newren <newren@gmail.com> writes:
>
>> +             entry = dir_rename_find_entry(dir_renames, old_dir);
>> +             if (!entry) {
>> +                     entry = xcalloc(1, sizeof(struct dir_rename_entry));
>> +                     hashmap_entry_init(entry, strhash(old_dir));
>
> Please make these two lines into its own dir_rename_entry_init()
> helper.
<snip>
> we'd want to see its string_list member to be
> initialised explicitly

Will do.