From: Elijah Newren Date: Wed, 22 Apr 2026 14:45:24 GMT Subject: Re: [PATCH v2 00/16] repack: incremental MIDX/bitmap-based repacking Message-ID: In-Reply-To: On Tue, Apr 21, 2026 at 1:37 PM Taylor Blau wrote: > > [Note to the maintainer, this is rebased onto current 'master', which is > 94f057755b7 (Git 2.54, 2026-04-19) at the time of writing.] > > This a modest-sized reroll of my series to implement the last remaining > component of the incremental MIDX/bitmap-based repacking strategy that I > have been working on. > > The main changes since last time are described in [1], which I sent to > the list last week just before the 2.54 release was tagged. For > convenience, a copy of the main changes are below: > > - Use a strset instead of a string_list for keeping track of the MIDX > layers to retain when calling `either clear_midx_files_ext()` or > `clear_incremental_midx_files_ext()`. > > - A new patch to rewrite the logic for determining which MIDX layers > comprise the new chain via keep_hashes to build the array in order. > The subsequent patch converts that into a strvec, which no longer > requires direct manipulation. > > - The new "--checksum-only" option has been renamed to > "--no-write-chain-file", and various small implementation tweaks > (e.g., relying on `is_lock_file_locked()` to determine whether we > should update the chain file as opposed to reading the flags). > > As usual, a range-diff is included below as well for convenience. Thanks > in advance for reviewing! [...] > Range-diff against v1: [...] This round addresses all the (admittedly minor) pieces of feedback I had on v1, and I didn't spot anything new to comment on in looking over the changes in this round.