From: Elijah Newren Date: Fri, 19 Sep 2025 23:30:00 GMT Subject: Re: [PATCH v3 00/10] Cleanup xdfile_t and xrecord_t in xdiff. Message-ID: In-Reply-To: On Fri, Sep 19, 2025 at 8:16 AM Ezekiel Newren via GitGitGadget wrote: > > Changes since v2. > > * No patch changes, just resending to get patch 9 to show up on the mailing > list. > * A few tweaks to the cover letter. > > Changes since v1, to address review feedback. > > * Only include the clean up patches; The remaining patches will be split > into a separate series. > * Commit message clarifications. > * Minor style cleanups. > * Performance impacts included in commit message of patch 8. I read over this latest round and it addresses all my feedback from v1. On top of all the nice code cleanups that this series provides, I appreciate the new detailed performance comparisons in the commit message in patch 8; while this series as a whole doesn't make the code appreciably faster yet, it's really cool that you've highlighted another potential performance optimization (beyond the hashing one you already highlighted elsewhere on the list) that we'll likely be able to realize once you get some further preparatory refactoring done. Looking forward to it. I think this round is ready to merge to next.