From: Elijah Newren <newren@gmail.com>
Date: Sat, 07 May 2022 04:14:07 GMT
Subject: Re: Crashes in t/t4058-diff-duplicates.sh
Message-ID: <CABPp-BEb8saqS0awK77y+-3oB1LAOPwOw-2dZU=67wJOKLBS1Q@mail.gmail.com>
In-Reply-To: <xmqqv8uioc7p.fsf@gitster.g>

On Fri, May 6, 2022 at 9:30 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Alex Riesen <alexander.riesen@cetitec.com> writes:
>
> > Taylor Blau, Fri, May 06, 2022 05:31:12 +0200:
>
> >> t4058.16, which blames back to ac14de13b2 (t4058: explore duplicate tree
>
> That commit talks about "trees with duplicate entries".  Does it
> mean a bad history where a tree object has two or more entries under
> the same name?

Yes.

> We should of course be catching these things at fsck
> time and rejecting at network transfer time, but I agree it is not a
> good excuse for us to segfault.  We should diagnose it as a broken
> tree object and actively refuse to proceed by calling die().