From: Elijah Newren Date: Sat, 08 Aug 2026 07:26:56 GMT Subject: Re: [PATCH v2 00/12] fast-import: standardize usage string and SYNOPSIS Message-ID: In-Reply-To: <20260804100355.1299498-1-christian.couder@gmail.com> On Tue, Aug 4, 2026 at 3:04 AM Christian Couder wrote: > > The goal of this series is to improve on `git fast-import`'s usage > string as it is obsolete in many ways. > > As it appeared that a good way to reach that goal was to make > `git fast-import` use the parse-options API, this series also achieves > this secondary goal. > > Along the way it modernizes "builtin/fast-import.c" mostly by using > `struct option`, by starting to remove global variables and libify > that command, and by introducing a new `OPT_HIDDEN_GROUP` macro. > > There are still many global variables left, so it's left to future > work to finish on that direction. > > Anyway the usage string is standardized and consistent with the > SYNOPSIS in the docs, so that the command can be removed from > "t/t0450/adoc-help-mismatches". > > Using the parse-options API also enabled some code standardization and > simplification. Thanks for doing the cleanup. I read through the series and I'm pretty happy with it; I only found a few minor things to comment on in three of the patches.