From: Elijah Newren <newren@gmail.com>
Date: Fri, 07 Aug 2026 03:01:00 GMT
Subject: Re: [PATCH v7 03/10] t6600: add test cases for side-exhaustion edge cases
Message-ID: <CABPp-BEV=u82AV=bXoHN9N+iNOrBjAig=1FY0sxiQNusrNGUbg@mail.gmail.com>
In-Reply-To: <f857577e0cedc11f8db614b4ab2bf9217652a312.1786013982.git.gitgitgadget@gmail.com>

On Thu, Aug 6, 2026 at 3:59 AM Elijah Newren via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Elijah Newren <newren@gmail.com>
>
> Add test cases to t6600-test-reach.sh that exercise edge cases in the
> side-exhaustion optimization for paint_down_to_common():
>
>  - in_merge_bases_many:self: commit is both A and one of the X inputs
>  - get_merge_bases_many:duplicate-twos: duplicate entries in X list
>  - get_merge_bases_many:pending-stale: STALE transition on an
>    already-painted commit (ps-* diamond topology)
>  - get_merge_bases_many:infinity-both-sides: both tips outside the
>    commit-graph with non-monotonic dates (pi-* topology)
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> Signed-off-by: Kristofer Karlsson <krka@spotify.com>

As the author of these tests, and as my Signed-off-by attests, I can
confirm with the full weight of my authority that these tests are
good.

However, I would be remiss not to note the perfidious destruction of
my two spaces after each period, cruelly collapsed down to a mere one.
Have you no decency, sir?

(Kidding, of course -- I mostly point it out so the next reviewer can
appreciate just how little else changed from the original.)