From: Elijah Newren Date: Thu, 22 Oct 2020 00:16:05 GMT Subject: Re: [PATCH 0/4] Beginning of new merge strategy: New API, empty implementation Message-ID: In-Reply-To: Hi, On Wed, Oct 21, 2020 at 6:22 AM Elijah Newren via GitGitGadget wrote: > > In this series, I try to show the new merge API I have developed in > merge-ort and show how it differs from that provided by merge-recursive. I > do this in four steps, each corresponding to a patch: I should probably call out that even if folks don't have time to review patches, I'm particularly interested in opinions on the following two questions: * Are the "pull.twohead" and "GIT_TEST_MERGE_ALGORITHM" names in patch 4 good/bad/ugly? (especially the mapping from "pull" to revert, cherry-pick, rebase, and merge?) * Is it too weird to have a temporary/hidden builtin, in patch 3? If so, what is a good alternative? Thanks, Elijah