From: Elijah Newren <newren@gmail.com>
Date: Tue, 14 Jan 2020 21:13:10 GMT
Subject: Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent
Message-ID: <CABPp-BEG-z4cQujWtvcfMPh8fDZeScbr=OLEW5FhXQKkFcjbWw@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2001142203450.46@tvgsbejvaqbjf.bet>

Hi Dscho,

On Tue, Jan 14, 2020 at 1:07 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> Hi,
>
>
> On Tue, 14 Jan 2020, Elijah Newren via GitGitGadget wrote:
>
> > Restructure the code slightly to avoid passing around a struct dirent
> > anywhere, which also enables us to avoid trying to manufacture one.
>
> Please note that due a bug (which has been fixed in the meantime, see
> https://github.com/gitgitgadget/gitgitgadget/pull/188 for details), this
> GitGitGadget mail is missing the line
>
>         From: Jeff King <peff@peff.net>

Thanks for the heads up.  Once Peff provides his Signed-off-by, I'll
add it to the patch and resubmit which will hopefully fix both the
from and the signed-off-by at the same time.

> The patch itself looks fine to me.
>
> Thanks,
> Dscho