From: Elijah Newren <newren@gmail.com>
Date: Tue, 13 Jan 2026 06:01:23 GMT
Subject: Re: [PATCH v10 0/8] Introduce git-history(1) command for easy history editing
Message-ID: <CABPp-BEDpjfxLrB5nWS+DkkTBKR+Le+jJhQiJCio=WkruchioA@mail.gmail.com>
In-Reply-To: <20260112-b4-pks-history-builtin-v10-0-e3c6aa5b4cec@pks.im>

On Mon, Jan 12, 2026 at 6:17 AM Patrick Steinhardt <ps@pks.im> wrote:
[...]
> Changes in v10:
>   - Split out changes that make `replay_revisions()` handle empty
>     revision ranges properly.
>   - Drop redundant `struct repository` parameter in
>     `replay_revisions()`.
>   - Move around `die_for_incompatible_opt2()`.
>   - Fix up some of the headers in "replay.c".
>   - Split out the changes that make `replay_revisions()` handle empty
>     revision ranges properly.
>   - Create a separate commit that fixes updating detached HEAD.
>   - Strip "encoding" header as we're reencoding commit messages.
>   - Merge the logic to update refs in in `REF_ACTION_HEAD` and
>     `REF_ACTION_BRANCHES` modes.
>   - Link to v9: https://lore.kernel.org/r/20260109-b4-pks-history-builtin-v9-0-8766101814c6@pks.im

Both Junio and I highlighted some changes in patch 1 (you already
indicated your agreement with Junio), and I had some minor rewording
suggestions for the commit message of patch 4.  All other patches in
v10 look good to me.