From: Erik Faye-Lund Date: Fri, 18 Nov 2011 14:19:37 GMT Subject: Re: [PATCH] honour GIT_ASKPASS for querying username in git-svn Message-ID: In-Reply-To: <4EC65DE4.90005@tu-clausthal.de> On Fri, Nov 18, 2011 at 2:30 PM, Sven Strickroth wrote: > Am 18.11.2011 12:36 schrieb Erik Faye-Lund: >> On Thu, Nov 17, 2011 at 4:15 PM, Sven Strickroth >> wrote: >>> From 8e576705ca949c32ff22d3216006073ee70652eb Mon Sep 17 00:00:00 2001 >>> From: Sven Strickroth >>> Date: Thu, 17 Nov 2011 15:43:25 +0100 >>> Subject: [PATCH 1/2] honour GIT_ASKPASS for querying username >>> >>> git-svn reads usernames from an interactive terminal. >>> This behavior cause GUIs to hang waiting for git-svn to >>> complete (http://code.google.com/p/tortoisegit/issues/detail?id=967). >>> >>> Also see commit 56a853b62c0ae7ebaad0a7a0a704f5ef561eb795. >>> >>> Signed-off-by: Sven Strickroth >> >> IIUC, GIT_ASKPASS is intended for passwords and not usernames. Won't >> this cause console-users to not see their username prompted anymore? > > git also asks for username using the GIT_ASKPASS tool (if GIT_ASKPASS is > set). > You are right, it does. Documentation/config.txt documents it as being for passwords without mentioning that it also affects usernames, that's why I wondered. I've also verified what happens here on my config, and git-svn doesn't prompt my username here without the patch either. So consider my comment withdrawn ;)