From: Erik Faye-Lund Date: Wed, 16 Apr 2014 09:55:49 GMT Subject: Re: [PATCH 6/6] xdiff/xprepare.c: reduce scope of variables Message-ID: In-Reply-To: <1397640811-17719-6-git-send-email-gitter.spiros@gmail.com> On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto wrote: > Signed-off-by: Elia Pinto > --- > xdiff/xprepare.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c > index 63a22c6..e0b6987 100644 > --- a/xdiff/xprepare.c > +++ b/xdiff/xprepare.c > @@ -161,8 +161,7 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_ > xdlclassifier_t *cf, xdfile_t *xdf) { > unsigned int hbits; > long nrec, hsize, bsize; > - unsigned long hav; > - char const *blk, *cur, *top, *prev; > + char const *blk, *cur, *prev; > xrecord_t *crec; > xrecord_t **recs, **rrecs; > xrecord_t **rhash; > @@ -193,7 +192,9 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_ > > nrec = 0; > if ((cur = blk = xdl_mmfile_first(mf, &bsize)) != NULL) { > + char const *top; > for (top = blk + bsize; cur < top; ) { > + unsigned long hav; > prev = cur; We do not indent with spaces.