From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Fri, 07 Jun 2013 10:01:15 GMT
Subject: Re: [PATCH] t0005: skip signal death exit code test on Windows
Message-ID: <CABPQNSa+nZY2V44B-L47aqwt=4eKr96jtadgKHhS__29tTvsdg@mail.gmail.com>
In-Reply-To: <51B02D81.3000700@viscovery.net>

On Thu, Jun 6, 2013 at 8:34 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> From: Johannes Sixt <j6t@kdbg.org>
>
> The test case depends on that test-sigchain can commit suicide by a call
> to raise(SIGTERM) in a way that run-command.c::wait_or_whine() can detect
> as death through a signal. There are no POSIX signals on Windows, and a
> sufficiently close emulation is not available in the Microsoft C runtime
> (and probably not even possible).
>
> The particular deficiency is that when a signal is raise()d whose SIG_DFL
> action will cause process death (SIGTERM in this case), the
> implementation of raise() just calls exit(3).
>
> We could check for exit code 3 in addition to 143, but that would miss
> the point of the test entirely. Hence, just skip it on Windows.
>

Huh? We do "exit(128 + sigint);" in mingw_raise these days, no?

Or is the signal triggered from a non-git process?