From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Mon, 28 Apr 2014 20:13:17 GMT
Subject: Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64
Message-ID: <CABPQNSZxk-cBCNhH4KwCGC2TGCQQ0TvMX=oOL31Eup=y6ZPm1A@mail.gmail.com>
In-Reply-To: <535EB32B.4050209@web.de>

On Mon, Apr 28, 2014 at 9:59 PM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 2014-04-28 15.51, Marat Radchenko wrote:
>> mingw-w64 has lseek defined in io.h.
> []
>>  #define off_t off64_t
>> +#ifndef lseek
>>  #define lseek _lseeki64
>> +#endif
> Is the commit message in line with the code?
>
> I would have expected something in this style:
>
> #if defined(__x86_64__) && ! defined(lseek))
> #include <io.h>
> #endif

No, we want 64-bit off_t either way, to support large files. So we
need the version that takes a 64-bit argument.