From: Erik Faye-Lund Date: Mon, 21 Oct 2013 19:07:26 GMT Subject: Re: [PATCH] Prevent buffer overflows when path is too big Message-ID: In-Reply-To: <52657A3D.8090609@kdbg.org> On Mon, Oct 21, 2013 at 9:02 PM, Johannes Sixt wrote: > Am 21.10.2013 03:31, schrieb Duy Nguyen: >> On Mon, Oct 21, 2013 at 12:57 AM, Antoine Pelisse wrote: >>> My main motive was to not *stop* the process when a long path is met. >>> Because somebody created a repository on Linux with a long file-name >>> doesn't mean you should not be able to clone it *at all* on Windows. >> >> That should be handled at the Windows compatibility layer if Windows >> cannot handle long paths as Linux > > Naah... PATH_MAX is a silly, arbitrary limit. The Git data model does > not forbid paths longer than PATH_MAX, be it 4096 or 260. A generic > solution is needed. > >> (or maybe at higher level to skip >> checking out those paths). > > More like this, yeah. I would argue that this is probably even a bug on Linux, only harder (if not impossible) to trigger by accident as there's probably no git-client that will generate such trees. But a "malicious" client might. -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.