From: Erik Faye-Lund Date: Wed, 23 Apr 2014 09:30:36 GMT Subject: Re: [PATCH v3] send-email: recognize absolute path on Windows Message-ID: In-Reply-To: On Tue, Apr 22, 2014 at 6:50 PM, Junio C Hamano wrote: > Erik Faye-Lund writes: > >>>> Shouldn't the latter also be anchored at the beginning of the string >>>> with a leading "^"? >>>> >>>>> + } >>>>> + >>>>> + require File::Spec::Functions; >>>>> + return File::Spec::Functions::file_name_is_absolute($path); >>>> >>>> We already "use File::Spec qw(something else)" at the beginning, no? >>>> Why not throw file_name_is_absolute into that qw() instead? >>> >>> Ahh, OK, if you did so, you won't have any place to hook the "only >>> on msys do this" trick into. >>> >>> It somehow feels somewhat confusing that we define a sub with the >>> same name as the system one, while not overriding it entirely but >>> delegate back to the system one. I am debating myself if it is more >>> obvious if it is done this way: >>> >>> use File::Spec::Functions qw(file_name_is_absolute); >>> if ($^O eq 'msys') { >>> sub file_name_is_absolute { >>> return $_[0] =~ /^\// || $_[0] =~ /^[A-Z]:/i; >>> } >>> } >>> >> >> In this case, we end up requiring that module even when we end up >> using it, no? > > Also somebody earlier mentioned that we would be redefining, which > has a different kind of ugliness, so I'd agree with the code structure > of what you sent out (which has been queued on 'pu'). > > My earlier question "don't we want to make sure 'C:' is at the > betginning of the string?" still stands, though. I do not think I > futzed with your regexp in the version I queued on 'pu'. Ah, yes of course. Thanks for spotting that. I also like the other clean-ups you did to the regex (above). -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.