From: Erik Faye-Lund Date: Thu, 14 Mar 2013 23:00:58 GMT Subject: Re: [PATCH/RFC] http_init: only initialize SSL for https Message-ID: In-Reply-To: <7vk3p9wqh5.fsf@alter.siamese.dyndns.org> On Thu, Mar 14, 2013 at 11:45 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> Apparently, ftps is also handled by cURL and most likely requires SSL. >> >> How about optimizing for the common case and instead of prefixcmp(url, >> "https:")) ask for !prefixcmp(url, "http:")? > > I think that is a very sensible way to go. > > As to ALL vs DEFAULT, given that its manual page is riddled with a > scary warning: > > This function must be called at least once within a program (a > program is all the code that shares a memory space) before the > program calls any other function in libcurl. The environment it sets > up is constant for the life of the program and is the same for every > program, so multiple calls have the same effect as one call. ... In > normal operation, you must specify CURL_GLOBAL_ALL. Don't use any > other value unless you are familiar with it and mean to control > internal operations of libcurl. > > I think we should stick to ALL. So > > flags = CURL_GLOBAL_ALL; > if (!prefixcmp(url, "http:")) > flags &= ~CURL_GLOBAL_SSL; > > would be the way to go. > > But this is assuming that nobody feeds our client a http:// URL to > the server that redirects us to the https:// version (or we do not > follow such a redirect). I offhand do not know if that is a valid > assumption, though. > Thanks, both. Very sensible points. I'll re-roll a new version tomorrow, but it could indeed be that the redirect-case can make this a no-go. -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.