From: Erik Faye-Lund Date: Fri, 17 Jan 2014 19:08:51 GMT Subject: Re: [PATCH 1/2] prefer xwrite instead of write Message-ID: In-Reply-To: On Fri, Jan 17, 2014 at 8:07 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Hi, >> >> Erik Faye-Lund wrote: >> >>> --- a/builtin/merge.c >>> +++ b/builtin/merge.c >>> @@ -367,7 +367,7 @@ static void squash_message(struct commit *commit, struct commit_list *remotehead >>> sha1_to_hex(commit->object.sha1)); >>> pretty_print_commit(&ctx, commit, &out); >>> } >>> - if (write(fd, out.buf, out.len) < 0) >>> + if (xwrite(fd, out.buf, out.len) < 0) >>> die_errno(_("Writing SQUASH_MSG")); >> >> Shouldn't this use write_in_full() to avoid a silently truncated result? (*) > > Meaning this? If so, I think it makes sense. > Yeah, I think that's better. Thanks, both! -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.