From: Erik Faye-Lund Date: Sun, 24 Jun 2012 15:38:24 GMT Subject: Re: [PATCH/RFC] compat/terminal: support echoing on windows Message-ID: In-Reply-To: On Sun, Jun 24, 2012 at 4:38 PM, Johannes Schindelin wrote: > Hi, > > On Sun, 24 Jun 2012, Erik Faye-Lund wrote: > >> Without /dev/tty support, git_terminal_prompt simply ignores the >> 'echo'-parameter. On Windows we can do better by clevering up our >> getpass-implementation a bit so it can conditionally echo. >> >> While we're at it, plug a small memory-leak by returning a pointer >> to a static strbuf instead of detaching it. This is the same thing >> the /dev/tty-version of git_terminal_prompt does, and the callee >> doesn't expect to have to free it's memory. > > Looks good, please apply! Done. -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en