From: Erik Faye-Lund Date: Mon, 28 Apr 2014 13:24:12 GMT Subject: Re: Re: git version 1.9.0 missing git-http-push? Message-ID: In-Reply-To: On Mon, Apr 28, 2014 at 3:20 PM, Johannes Schindelin wrote: > Hi kusma, > > On Mon, 28 Apr 2014, Erik Faye-Lund wrote: > >> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: >> > So it seems that 08900987 ("Decide whether to build http-push in the >> > Makefile") makes a bad assumption about the availability of >> > curl-config on new libcurl installations; it's not present on "stock" >> > Windows builds. >> >> I wonder, though. That check is over 8 years old. Are that old systems >> (that haven't been upgraded) still able to build Git? Even my old >> RedHat 5 setup has curl 7.15.5... > > The easiest way in my humble opinion would be to install a script like > this into /mingw/bin/: > > -- snip -- > #!/bin/sh > > case "$1" in > --vernum) > version="$(curl -V)" || exit > version="$(echo "${version%% (*)*}" | tr . \ )" > eval printf "%02d%02d%02d" ${version#curl } > ;; > --cflags) > ;; > --libs) > echo -lcurl > ;; > esac > -- snap -- > > That way, upstream Git does not have anything to change (and we avoid > discussing five versions of essentially the same patch :-P). Huh? I think I only really proposed one patch...? -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.