From: Mahendra Dani <danimahendra0904@gmail.com>
Date: Tue, 04 Mar 2025 17:49:41 GMT
Subject: Re: [PATCH 1/1] t1403: prefer test_path_exists helper function
Message-ID: <CABGrwBBbtiWtMnwJV3Pefo8VDH2LYWsH2QKG-TG_AEdZq5585A@mail.gmail.com>
In-Reply-To: <xmqqsensr8r9.fsf@gitster.g>

On Tue, Mar 4, 2025 at 11:14 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Mahendra Dani <danimahendra0904@gmail.com> writes:
>
> > Yes, due to the use of the "-f" flag, it's not necessary to explicitly
> > check the lack of file using `test -e`.
> > But if we drop the "-f" flag, we will have to check the lack of file
> > using `test -e` or
> > `test_path_is_file()`.
>
> Isn't it the other way around?
>
>     $ rm -f nosuch ; echo $?
>     0
>     $ rm nosuch ; echo $?
>     rm: cannot remove 'nosuch': No such file or directory
>     1
>

Yes, you are right.
With the "-f" flag, `rm` returns exit code 0 irrespective of whether
the file is present or not.
Thus, the `test -e` check is _required_ if we drop the "-f" flag to
return the correct exit code.

I apologize for the mistake.

Thanks,
Mahendra