From: Raymundo <gypark@gmail.com>
Date: Wed, 25 Nov 2015 14:00:24 GMT
Subject: Re: 'git log --source' seems to fail to show ref name after the first tag comes out.
Message-ID: <CAAe7MbDu-Z7585A6tDcFg78pRrnDjvmdZV7oqGkqO8XchZUzaA@mail.gmail.com>
In-Reply-To: <20151125125956.GC4504@sigill.intra.peff.net>

2015-11-25 21:59 GMT+09:00 Jeff King <peff@peff.net>:
>
> Sounds like a good opportunity to use git-bisect. I came up with 2073949
> (traverse_commit_list: support pending blobs/trees with paths,
> 2014-10-15) from git v2.2.0, which unfortunately was written by me. :)
>
> This one-liner seems to fix it:
>
> diff --git a/revision.c b/revision.c
> index af2a18e..d434b8b 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -297,7 +297,6 @@ static struct commit *handle_commit(struct rev_info *revs,
>                  * through to the non-tag handlers below. Do not
>                  * propagate data from the tag's pending entry.
>                  */
> -               name = "";
>                 path = NULL;
>                 mode = 0;
>         }
>
> But I'm not sure if it causes other problems. In particular, I see why
> we would not propagate a path field, but I do not know why the original
> was avoiding propagating the name field.
>
> -Peff

It's a good news that you found the reason so soon.

I'd like to wait for next version :-)

Thank you!