From: Thomas Bachem <mail@thomasbachem.com>
Date: Mon, 07 Sep 2026 16:35:47 GMT
Subject: Re: [PATCH v2 3/3] sequencer: keep auto maintenance out of the commands a sequence spawns
Message-ID: <CAA0xjtrherFZZBSeqE8zd6Kbwy_=f9mwiqJK832DzZRakkiwBw@mail.gmail.com>
In-Reply-To: <ap5yWS5tKLej7BjT@pks.im>

Hi Patrick,

On 07/09/2026 10:14, Patrick Steinhardt wrote:
> Why do you set both "maintenance.auto" and "gc.auto"? Setting only the
> former should be sufficient, as maintenance uses git-maintenance(1)
> exclusively nowadays. Sure, it may trigger git-gc(1) internally. But it
> won't ever do so if auto-maintenance is completely disabled.

You're right. prepare_auto_maintenance() looks at gc.auto only when
maintenance.auto is unset, so maintenance.auto alone is enough.
gc.auto=0 would still stop an exec that runs "git gc --auto" itself,
but I don't think we need to guard against that. I'll drop it in v3.

Thanks,
Thomas