From: Thomas Bachem <mail@thomasbachem.com>
Date: Thu, 03 Sep 2026 12:12:11 GMT
Subject: Re: [PATCH 0/2] builtin/maintenance: improve heuristic for "rerere gc"
Message-ID: <CAA0xjtoUzHf0bGzydZ9PR=sgz=mdA=4pDDkHr5uJhv9fT9ShsA@mail.gmail.com>
In-Reply-To: <20260903-b4-pks-maintenance-rerere-gc-heuristic-v1-0-9929c45a9788@pks.im>

Hi Patrick,

On Thu, Sep 03, 2026 at 11:04:56AM +0200, Patrick Steinhardt wrote:
> as reported and discussed in [1]. Thanks!

Thanks for the quick turnaround. I built the series on 3cb9185f65,
t4200 and t7900 pass, and it does what the commit message says: with
the default of 512, a single stale entry in the sample is not enough
and two are, and fresh entries never trigger it however many there
are.

That takes the gc out of my repro, for two reasons: its 20000 entries
are fresh, and their names come from a counter rather than a hash, so
none starts with 17 and the sampler never sees them. With 5000 real
hashes as names, all older than the cutoff, "git maintenance
is-needed --auto --task=rerere-gc" reports it as needed again, so the
repro in v2 will look like that.

Tested-by: Thomas Bachem <mail@thomasbachem.com>

Thanks,
Tom