From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
Date: Thu, 19 Sep 2013 06:04:40 GMT
Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined
Message-ID: <CAA01CsrN+VLw4WQmObvh72_MoH1Lyh9dQbizJcVhqyJoRyms-Q@mail.gmail.com>
In-Reply-To: <20130911191620.GB24251@sigill.intra.peff.net>

On Wed, Sep 11, 2013 at 9:16 PM, Jeff King <peff@peff.net> wrote:
> I would prefer the static wrapper solution you suggest, though. It
> leaves the compiler free to optimize the common case of normal
> strcasecmp calls, and only introduces an extra function indirection when
> using it as a callback (and even then, if we can inline the strcasecmp,
> it still ends up as a single function call). The downside is that it has
> to be remembered at each site that uses strcasecmp, but we do not use
> pointers to standard library functions very often.

Is it possible to add a test which fails if wrapper is not used?

-- 
Piotr Krukowiecki