From: Sebastian Staudt <koraktor@gmail.com>
Date: Wed, 30 Jan 2019 10:23:36 GMT
Subject: Re: [PATCH v3 3/3] Add test for describe with a bare repository
Message-ID: <CA+xP2SZnmTHGd5rB8BtXMNnCoz0SEFdgT-vcgRttJxBdA04ciA@mail.gmail.com>
In-Reply-To: <20190129131243.GC22211@sigill.intra.peff.net>

Am Di., 29. Jan. 2019 um 14:12 Uhr schrieb Jeff King <peff@peff.net>:
>
> On Tue, Jan 29, 2019 at 06:18:59AM +0100, Sebastian Staudt wrote:
>
> > This ensures that nothing breaks the basic functionality of describe for
> > bare repositories. Please note that --broken and --dirty need a working
> > tree.
>
> Makes sense.
>
> > +test_expect_success 'describe works from outside repo using --git-dir' "
> > +  git clone --bare '$TRASH_DIRECTORY' '$TRASH_DIRECTORY/bare' &&
> > +  git --git-dir '$TRASH_DIRECTORY/bare' describe
> > +"
>
> What the test is doing seems sane, but the same quoting comments from
> the earlier patch apply.
>

Ok, thanks.

> -Peff