From: Brandon Casey <drafnel@gmail.com>
Date: Tue, 12 Feb 2013 22:51:48 GMT
Subject: Re: [PATCH v4 11/12] format-patch: update append_signoff prototype
Message-ID: <CA+sFfMcJf2Jdjs8T3Sxx6gZGNrrtNYQog5p33NV0QOf4dAP-Ww@mail.gmail.com>
In-Reply-To: <7v1uclgwk7.fsf@alter.siamese.dyndns.org>

On Tue, Feb 12, 2013 at 11:29 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Brandon Casey <drafnel@gmail.com> writes:

>> diff --git a/builtin/log.c b/builtin/log.c
>> index 8f0b2e8..59de484 100644
>> --- a/builtin/log.c
>> +++ b/builtin/log.c

>> @@ -253,9 +255,12 @@ static int detect_any_signoff(char *letter, int size)
>>       return seen_head && seen_name;
>>  }
>>
>> -static void append_signoff(struct strbuf *sb, const char *signoff)
>> +static void append_signoff(struct strbuf *sb, int ignore_footer, unsigned flag)
>>  {
>> +     unsigned no_dup_sob = flag & APPEND_SIGNOFF_DEDUP;
>
> Unused variable at this step?

Yeah, looks like that line can be dropped.

-Brandon