From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date: Thu, 16 Jul 2026 15:36:36 GMT
Subject: Re: [GSoC Patch 7/7] repo: add path.git-prefix path key validation
Message-ID: <CA+rGoLfXGNydaUBz6qjfrHvYZ6T_jCQuoxO_yx1K7jEtqEMpNg@mail.gmail.com>
In-Reply-To: <xmqqech3k47u.fsf@gitster.g>

Hey Junio,

On Thu, Jul 16, 2026 at 8:53 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:
>
> > diff --git a/builtin/repo.c b/builtin/repo.c
> > index a97ad71649..00d5064281 100644
> > --- a/builtin/repo.c
> > +++ b/builtin/repo.c
> > @@ -1,3 +1,4 @@
> > +#include "compat/posix.h"
> >  #define USE_THE_REPOSITORY_VARIABLE
> >  #include "builtin.h"
>
> The first include must be <git-compat-util.h> or common include
> files that include <git-compat-util.h> as the first thing, like
> <builtin.h>.
>
> As the file already includes <builtin.h>, extra inclusion of
> <compat/posix.h> before everything else is an absolute no-no.
>


Oh no, that's just my editor adding headers automatically.
Thanks for pointing this out, I will fix it.

> By the way, I do not see any "validation" in the patch as the title
> claims.  Perhaps retitle it to "repo: add path.git-prefix key" or
> something simpler like that?
>

True, I will correct that as well.

Regards,
- K Jayatheerth