From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date: Tue, 09 Jun 2026 02:27:10 GMT
Subject: Re: [GSoC PATCH v2 1/4] path: introduce format_path() for centralized path formatting
Message-ID: <CA+rGoLckSpPq5iHUsgUQpXGopS4-9LCh4=pxRt0rkRpdNNoemQ@mail.gmail.com>
In-Reply-To: <bd9bc9aa-60b6-4e5d-9ce1-bf38b6032309@app.fastmail.com>

> > the localized fallback mechanics specific to `rev-parse`.
>
> This looks very well explained to my naive eyes.

Thank you!


> Nitpick. You are supposed to add your `Signed-off-by` at the end. You
> are saying with that line that you are signing off on the changes and
> the commit message, including the trailers (mentors) you’ve decided to
> add. Imagine if the maintainer applies this patch and fixes a typo and
> the commit becomes:
>
>     Mentored-by: Justin Tobler <jltobler@gmail.com>
>     Mentored-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
>     Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
>     [jc: typo fix]
>     Signed-off-by: Junio ...
>
> The chain of custody is then very clear.
>
> > ---
> >[snip]

Ok, I understand
thanks for taking time to explain that

Will change it in the next patch series.