From: Simon Perrat <simon.perrat@gmail.com>
Date: Tue, 12 Jun 2012 09:56:18 GMT
Subject: Re: [PATCHv2 2/2] git-remote-mediawiki: refactoring get_mw_pages function
Message-ID: <CA+hdvHhvnku_h95LT7se7JWOZh4cG2UB4AfwAs2jV1j2hefDQw@mail.gmail.com>
In-Reply-To: <vpqmx48x4o5.fsf@bauges.imag.fr>

2012/6/12 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:
> Simon Perrat <simon.perrat@gmail.com> writes:
>
>> 2012/6/11 Pavel Volek <Pavel.Volek@ensimag.imag.fr>:
>>
>>> +sub get_mw_all_pages {
>>> +       my $pages = shift;
>>> +       # No user-provided list, get the list of pages from the API.
>>> +       my $mw_pages = $mediawiki->list({
>>> +               action => 'query',
>>> +               list => 'allpages',
>>> +               aplimit => 500
>>> +       });
>>
>> Indentation should be 8 columns wide.
>
> More precisely, indentation in Git is done with tabs, and should display
> well with 1 tab == 8 characters.
>
> It is actually the case in Pavel's patch. When seen as patches, the
> first column is used for + and -, so the first tab is rendered as only 7
> characters, but that's normal.
>
> Or did I miss something?
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/

My bad, I was mistaken by my mailer, which displayed these two lines
with a four-columns tab while the others were eight-columns.