From: Simon Perrat <simon.perrat@ensimag.imag.fr>
Date: Tue, 12 Jun 2012 13:58:51 GMT
Subject: Re: [PATCHv3 4/6] Tests for git-remote-mediawiki pull
Message-ID: <CA+hdvHgz0EFXMk2C9SA2AnDeeh9i8Eo7WPdYvkotLEN8og892A@mail.gmail.com>
In-Reply-To: <20120611230954.Horde.inb-aHwdC4BP1l6iLlHhZgA@webmail.minatec.grenoble-inp.fr>

2012/6/11  <konglu@minatec.inpg.fr>:
>
> Simon Cathebras <simon.cathebras@ensimag.imag.fr> a écrit :
>
>
>> +test_expect_success 'Git pull works after adding a new wiki page' "
>> +        wiki_reset &&
>> +       cd $TRASH_DIR &&
>> +       rm -rf mw_dir &&
>> +       rm -rf ref_page &&
>> +
>> +        git clone mediawiki::http://$SERVER_ADDR/$WIKI_DIR_NAME mw_dir &&
>> +        wiki_editpage Foo \"page created after the git clone\" false &&
>> +
>> +        cd mw_dir &&
>> +        git pull &&
>> +        cd .. &&
>> +
>> +        rm -rf ref_page &&
>> +        wiki_getallpage ref_page &&
>> +        test_diff_directories mw_dir ref_page &&
>> +        rm -rf ref_page &&
>> +        rm -rf mw_dir
>> +"
>
>
> Why are there dquotes here (and all the following tests) ? You used
> simple quote in t9360.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

We corrected this to use simple quotes in all our tests; originally we
used double quotes because of $ in the scripts, now we're escaping
them.