From: Jacob Keller Date: Wed, 30 Mar 2016 19:31:30 GMT Subject: Re: weird diff output? Message-ID: In-Reply-To: On Wed, Mar 30, 2016 at 12:14 PM, Jacob Keller wrote: > I ran this on a few of my local projects and it doesn't seem to > produce any false positives so far. Everything looks good. Of course > this is with just traditional C code. I am currently trying to run > this against the history of Linux as well and see if I can find > anything that seems bad there. > > Thanks, > Jake So far I've only found a single location that ends up looking worse within the Linux kernel. Diffs of some Kbuild settings result in something like before: If unsure, say Y. + +config RMI4_I2C + tristate "RMI4 I2C Support" + depends on RMI4_CORE && I2C + help + Say Y here if you want to support RMI4 devices connected to an I2C + bus. + + If unsure, say Y. after: required for all RMI4 device support. + If unsure, say Y. + +config RMI4_I2C + tristate "RMI4 I2C Support" + depends on RMI4_CORE && I2C + help + Say Y here if you want to support RMI4 devices connected to an I2C + bus. + If unsure, say Y. So in this particular instance which has multiple blank lines and is a similar issue as with Stefan's note above, this is where the heuristic falls apart. At least for C code this is basically vanishingly small compared to the number of comment header fix ups. I think it may be that Stefan's suggestions above may be on the right track to resolve that too. Regards, Jake