From: Jacob Keller Date: Wed, 07 Sep 2016 22:28:10 GMT Subject: Re: [PATCH 3/3] patch-ids: use commit sha1 as patch-id for merge commits Message-ID: In-Reply-To: <20160907220439.ukbqnj5biaro2lxv@sigill.intra.peff.net> On Wed, Sep 7, 2016 at 3:04 PM, Jeff King wrote: > The patch-ids code which powers "log --cherry-pick" doesn't > look at whether each commit is a merge or not. It just feeds > the commit's first parent to the diff, and ignores any > additional parents. > The subject here is misleading since it says you will use sha1 of the merge commit ,but instead just ignore merge commits and indicate they have no patch id. I suspect this is because you switched implementations part way through developing this. Thanks, Jake