From: Jacob Keller Date: Wed, 24 Feb 2016 23:51:01 GMT Subject: Re: [PATCH] git: submodule honor -c credential.* from command line Message-ID: In-Reply-To: On Wed, Feb 24, 2016 at 3:36 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Wed, Feb 24, 2016 at 12:09 PM, Jacob Keller wrote: >>> From: Jacob Keller >>> >>> Due to the way that the git-submodule code works, it clears all local >>> git environment variables before entering submodules. This is normally >>> a good thing since we want to clear settings such as GIT_WORKTREE and >>> other variables which would affect the operation of submodule commands. >>> However, GIT_CONFIG_PARAMETERS is special, and we actually do want to >>> preserve these settings. However, we do not want to preserve all >>> configuration as many things should be left specific to the parent >>> project. >>> >>> Add a git submodule--helper function which can be used to sanitize the >>> GIT_CONFIG_PARAMETERS value to only allow certain settings. For now, >>> restrict this to only credential.* settings. >> >> I guess for now that subset is fine and will be expanded over time? > > I think it is more like "we pass only what is known to be necessary > and safe, and right now, credential.* are the only such variables." > > As the system evolves more, theoretically we might find more, but > let's not phrase it as if expanding is a good thing and a longer > term goal. > I can reword the commit message to that effect. Regards, Jake.