From: Jacob Keller Date: Tue, 04 Oct 2016 21:49:10 GMT Subject: Re: [PATCH 13/18] fill_sha1_file: write "boring" characters Message-ID: In-Reply-To: On Tue, Oct 4, 2016 at 2:46 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> On Mon, Oct 3, 2016 at 1:35 PM, Jeff King wrote: >>> This function forms a sha1 as "xx/yyyy...", but skips over >>> the slot for the slash rather than writing it, leaving it to >>> the caller to do so. It also does not bother to put in a >>> trailing NUL, even though every caller would want it (we're >>> forming a path which by definition is not a directory, so >>> the only thing to do with it is feed it to a system call). >>> >>> Let's make the lives of our callers easier by just writing >>> out the internal "/" and the NUL. >>> ... >> >> I think this makes a lot more sense than making the callers have to do this. > > The cost of fill function having to do the same thing repeatedly is > negligible, so I am OK with the result, but for fairness, this was > not "make the callers do this extra thing", but was "the caller can > prepare these unchanging parts just once, and the fill function that > is repeatedly run does not have to." > Sure, but it's a pretty minor optimization and I think the result is easier to understand. Thanks, Jake