From: Jacob Keller <jacob.keller@gmail.com>
Date: Wed, 10 Dec 2025 02:13:26 GMT
Subject: Re: About --staged ang --cached
Message-ID: <CA+P7+xr6HHCXsiXi=CDm=rccNO4b6gmjLbuWt4KLAEwSs20aww@mail.gmail.com>
In-Reply-To: <xmqqpl8ni7bo.fsf@gitster.g>

On Tue, Dec 9, 2025 at 3:07 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
> > Do you think that it would be relevant to add --staged to the other
> > commands just like [2] did to git-diff? Perhaps this is just a personal
> > issue, but I find it curious that those commands still have a flag named
> > after an obsolete name while newer commands are using --staged.
>
> As long as "Only in the index" aspect of the name is kept, I do not
> think the exact phrasing matters all that match.  The distinction
> between "apply --cached" vs "apply --index" must be expressable even
> if you swap "--cached" with something else.
>
> Would it be simpler to remove the label "obsoleted" from the name,
> and remove the "--staged" synonym?
>

I think it makes more sense to add a --staged synonym to commands with
--cached, than to go back the other way.