From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 07 Dec 2017 21:20:23 GMT
Subject: Re: [PATCH] diff: add tests for --relative without optional prefix value
Message-ID: <CA+P7+xr-aUm_=50gsrJ3TXpDzvi7LYzWPeamAC+TqzLyh_mY8w@mail.gmail.com>
In-Reply-To: <20171207211258.GB12850@sigill.intra.peff.net>

On Thu, Dec 7, 2017 at 1:12 PM, Jeff King <peff@peff.net> wrote:
> On Thu, Dec 07, 2017 at 11:01:35AM -0800, Jacob Keller wrote:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> We already have tests for --relative, but they currently only test when
>> a prefix has been provided. This fails to test the case where --relative
>> by itself should use the current directory as the prefix.
>>
>> Teach the check_$type functions to take a directory argument to indicate
>> which subdirectory to run the git commands in. Add a new test which uses
>> this to test --relative without a prefix value.
>
> This looks good to me (and I slightly prefer it over Junio's for the
> simplicity).
>
> I agree on the ordering suggestion Junio made.
>
> -Peff

As do I. Junio, if we go with my version, feel free to squash in the
re-order. Or if you prefer, I can send a v2 (though for such a small
change I don't see the benefit).

Thanks,
Jake