From: Jacob Keller <jacob.keller@gmail.com>
Date: Fri, 26 Feb 2016 02:19:17 GMT
Subject: Re: [PATCH v3 2/2] git: submodule honor -c credential.* from command line
Message-ID: <CA+P7+xqyTUh60BOmY03JHE6HyVqY7iidVkUf3ji95_s3uE32cg@mail.gmail.com>
In-Reply-To: <20160226015510.GA5347@flurp.local>

On Thu, Feb 25, 2016 at 5:55 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> Not worth a re-roll, but these quote sequences are brain-melting.
> Easier would have been to double-quote the second argument of
> test_expect_success() and then do either:
>

They are. I fiddled with things till I got it working. I wasn't sure
if double quotes would cause a problem or not, since most other tests
seemed to avoid it.

However this re-roll forgot to check argc in submodule--helper so
maybe worth reroll to fix both things?

Thanks
Jake