From: Jacob Keller <jacob.keller@gmail.com>
Date: Mon, 02 Mar 2026 22:06:52 GMT
Subject: Re: [PATCH v3] submodule: fetch missing objects from default remote
Message-ID: <CA+P7+xqtupp=E8+MOOEJ-nB84QnTXL7FD549LwEmfQiwoUNHzQ@mail.gmail.com>
In-Reply-To: <xmqq7bs08p4r.fsf@gitster.g>

On Wed, Feb 25, 2026 at 1:55 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Jacob Keller <jacob.keller@gmail.com> writes:
>
> > On Thu, Jan 22, 2026 at 10:49 AM Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >> Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> writes:
> >> ...
> >> Thanks.  Jacob, this v3 is not exactly the same as v1 that you
> >> reviewed (and range-diff relative to v2 does not capture what got
> >> changed between the version you saw and this version), but I just
> >> checked that they are "essentially identical" except for the
> >> proposed log message.  Are you happy with having your Reviewed-by on
> >> this version?
> >>
> >
> > I re-reviewed the patch and everything looks fine to me:
> >
> > Reviewed-by: Jacob Keller <jacob.keller@gmail.com>
>
> We actually needed a pair of small fixups on top, but I presume that
> even with them your reviewed-by still stands?
>

I'll re-review the latest version.