From: Jacob Keller <jacob.keller@gmail.com>
Date: Tue, 08 Mar 2016 01:56:40 GMT
Subject: Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier
Message-ID: <CA+P7+xqqA=aZ5Nr7YuMnLKAc2E3F4Y31oOb06aAcvunqw+gH4A@mail.gmail.com>
In-Reply-To: <xmqqtwkhnaxg.fsf@gitster.mtv.corp.google.com>

On Mon, Mar 7, 2016 at 3:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> The "%(symref)" atom doesn't work when used with the ':short' modifier
>> because we strictly match only 'symref' for setting the 'need_symref'
>> indicator. Fix this by using 'starts_with()' rather than 'strcmp()'.
>
> Does that mean you also accept %(symrefgarbage) without complaining?
>
>

Looks like patch 9 fixes this by introducing symref_atom_parser.

Regards,
Jake