From: Jacob Keller Date: Thu, 28 Apr 2016 15:25:41 GMT Subject: Re: [PATCH 2/5] t5550: break submodule config test into multiple sub-tests Message-ID: In-Reply-To: On Thu, Apr 28, 2016 at 8:21 AM, Stefan Beller wrote: > On Thu, Apr 28, 2016 at 6:37 AM, Jeff King wrote: >> Right now we test only the cloning case, but there are other >> interesting cases (e.g., fetching). Let's pull the setup >> bits into their own test, which will make things flow more >> logically once we start adding more tests which use the >> setup. >> >> Let's also introduce some whitespace to the clone-test to >> split the two parts: making sure it fails without our >> cmdline config, and that it succeeds with it. >> >> Signed-off-by: Jeff King >> --- >> t/t5550-http-fetch-dumb.sh | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh >> index 81cc57f..e8e91bb 100755 >> --- a/t/t5550-http-fetch-dumb.sh >> +++ b/t/t5550-http-fetch-dumb.sh >> @@ -91,17 +91,21 @@ test_expect_success 'configured username does not override URL' ' >> expect_askpass pass user@host >> ' >> >> -test_expect_success 'cmdline credential config passes into submodules' ' >> +test_expect_success 'set up repo with http submodules' ' > > set up or setup? > > $ grep -r "set up" |wc -l > 69 > $ grep -r "setup" |wc -l > 1162 > > Apart from that nit, this patch looks good to me. > Yes this looks quite a bit more readable. Thanks, Jake