From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 25 Aug 2016 20:35:34 GMT
Subject: Re: [PATCH v10 0/9] submodule inline diff format
Message-ID: <CA+P7+xpiHmTBqF1RT8zUd=1g=nKtMiwpH19DyhwLi9ikLQ8t8A@mail.gmail.com>
In-Reply-To: <xmqqlgznwg6o.fsf@gitster.mtv.corp.google.com>

On Tue, Aug 23, 2016 at 10:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I am not so sure about that.  If there is an existing place that is
> buggy, shouldn't we fix that, instead of spreading the same bug
> (assuming that it is a bug in the first place, which I do not have a
> strong opinion on, at least not yet)?
>

I was saying that I'm not sure it is a bug so I sided with preserving
behavior instead.

If it is indeed a bug we should fix it, and I'm trying to determine
whether it actually is a bug here, and what the best solution is.

If there is a bug and we should die, should we also introduce a
"_gently()" variant of these functions and thus fail properly if they
don't work so that we can report an error in producing a diff instead
of die()ing?

Thanks,
Jake