From: Jacob Keller <jacob.keller@gmail.com>
Date: Fri, 01 May 2020 21:53:32 GMT
Subject: Re: [PATCH 00/11] refactor git switch completion
Message-ID: <CA+P7+xpdNtRPOzR09DJNRZagqwEOt3-=mxye3qQk5XQ4guaJTg@mail.gmail.com>
In-Reply-To: <xmqqsggkpop0.fsf@gitster.c.googlers.com>

On Thu, Apr 30, 2020 at 3:57 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
> > From: Jacob Keller <jacob.keller@gmail.com>
> >
> > completion support for git switch is subpar for a number of cases. Most
> > notable is difference between these two completions:
> >
> >   $git switch <TAB>
> >   Display all 784 possibilities? (y or n)
> >   <list of all references and DWIM remotes>
> >
> >   $git switch --track<TAB>
> >   jk-refactor-git-switch-completion master`
> > ...
>
> We've discussed that it may be a good idea to make sure that "switch
> -c", "checkout -b" and "switch/checkout --orphan" complete the new
> branch name the same way, but haven't done anything else.  I'd very
> much appreciate to see the patches reviewed by those involved more
> in the completion script, before we decide to merge the topic to
> 'next'.


It is my intention to extend this series with a notion of reading the
previous word on the command line, and using that to determine if we
are completing an argument for an option.

Thanks,
Jake